Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename CAMARA_common.json to CAMARA_common.yaml #107

Merged

Conversation

shilpa-padgaonkar
Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar commented Dec 5, 2023

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

changes json to yaml
extends file with device schema
conforms to oas

Which issue(s) this PR fixes:

Fixes #106 #201 #105

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

patrice-conil
patrice-conil previously approved these changes Dec 5, 2023
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@hdamker
Copy link
Collaborator

hdamker commented Dec 13, 2023

@shilpa-padgaonkar: please see the linting results of a copy of the CAMARA_common.yaml in https://github.com/hdamker/QualityOnDemand/pull/4/files. There are some smaller issues which could easily be corrected.

I propose to open an issue to introduce linting also in the Commonalities repo.

@hdamker
Copy link
Collaborator

hdamker commented Dec 13, 2023

@jlurien @bigludo7 Would you have a view on the "extends file with device schema" part of this PR?

@rartych
Copy link
Collaborator

rartych commented Jan 8, 2024

CAMARA_common.json is referenced in section 7 of API Design Guidelines.
Beside the the change of the link the text of this section may need the update to indicate the target content and usage of CAMARA_common.yaml.

@shilpa-padgaonkar
Copy link
Collaborator Author

shilpa-padgaonkar commented Jan 8, 2024

@rartych : I have changed the link in design doc. If description needs to be changed, please create a new issue for it.

@shilpa-padgaonkar
Copy link
Collaborator Author

@bigludo7 @jlurien : Could you kindly review as suggested in the comment above to ensure that the device schema is as needed?

@shilpa-padgaonkar
Copy link
Collaborator Author

@RubenBG7 @jordonezlucena As code owners, could you kindly review this PR?
@patrice-conil : Thanks for your review earlier. I have made indentation related fixes after your review and also added the link change in design guideline doc. Would be very helpful if you kindly re-review.

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RubenBG7
Copy link
Collaborator

RubenBG7 commented Jan 8, 2024

Ok from TEF side to PR 107 too

@rartych
Copy link
Collaborator

rartych commented Jan 9, 2024

Merging as agreed.

@rartych rartych merged commit 2dc76ed into camaraproject:main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes for Camara-common file in artifacts
6 participants