Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send a CloudEvent when DELETE /subscriptions/{subscriptionId} #117

Open
maxl2287 opened this issue Feb 26, 2024 · 2 comments · May be fixed by #121
Open

Send a CloudEvent when DELETE /subscriptions/{subscriptionId} #117

maxl2287 opened this issue Feb 26, 2024 · 2 comments · May be fixed by #121
Labels
enhancement New feature or request

Comments

@maxl2287
Copy link
Contributor

maxl2287 commented Feb 26, 2024 •
edited

Problem description
Currently there is no description about a CloudEvent when the subscription will be deleted by a User via DELETE /subscriptions/{subscriptionId}.

Possible evolution

  • Update the description of `DELETE /subscriptions/{subscriptionId´ to mention that a CloudEvent will be send as well.
  • Add a terminationReason like DELETE_REQUESTED

see how QoD v0.10.0 is doing it when the user requested a deletion before subscription-expired.

https://github.com/camaraproject/QualityOnDemand/blob/v0.10.0/code/API_definitions/qod-api.yaml#L918
@maxl2287 maxl2287 added the enhancement New feature or request label Feb 26, 2024
@maxl2287 maxl2287 changed the title Send a CloudEvent when `DELETE /subscriptions/{subscriptionId´ Send a CloudEvent when `DELETE /subscriptions/{subscriptionId}´ Feb 26, 2024
@maxl2287 maxl2287 changed the title Send a CloudEvent when `DELETE /subscriptions/{subscriptionId}´ Send a CloudEvent when DELETE /subscriptions/{subscriptionId} Feb 26, 2024
@maxl2287 maxl2287 changed the title Send a CloudEvent when DELETE /subscriptions/{subscriptionId} Send a CloudEvent when DELETE /subscriptions/{subscriptionId} Feb 26, 2024
@akoshunyadi
Copy link
Collaborator

The same as this in DeviceLocation camaraproject/DeviceLocation#141 , there SUBSCRIPTION_DELETED has been proposed, which I would prefer here too.
DELETE_REQUESTED suggests that there will be another event with _DELETED.

@maxl2287 maxl2287 linked a pull request Mar 5, 2024 that will close this issue
Open
@bigludo7
Copy link
Collaborator

bigludo7 commented Mar 6, 2024

Look good for me but I check consistence with Device location (camaraproject/DeviceLocation#141) where same issue but not yet resolved.

@bigludo7 bigludo7 mentioned this issue Mar 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add termination reason when subscription deleted maxl2287/DeviceStatus
3 participants
@bigludo7 @akoshunyadi @maxl2287