Add termination reason SUBSCRIPTION_DELETED when subscription deleted by the user
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxl2287
requested review from
eric-murray,
bigludo7,
sachinvodafone and
akoshunyadi
as code owners
|
We should wait until the problem is solved in commonalities, we don't want to have proprietary solutions in each API |
|
The discussion about subscription lifecycle management in commonalities: camaraproject/Commonalities#153 |
|
waiting for megalinter fixes which are already done by #146 |
maxl2287
changed the title
maxl2287
changed the title
SUBSCRIPTION_DELETED when subscription deleted
maxl2287
changed the title
SUBSCRIPTION_DELETED when subscription deletedSUBSCRIPTION_DELETED when subscription deleted by the user
maxl2287
force-pushed
the
feature/cloud-event-when-delete-subscription
branch
from
c307c75
to
b20db75
Compare
…us-subscriptions.yaml
|
@camaraproject/device-status_maintainers |
akoshunyadi
reviewed
Jun 21, 2024
code/API_definitions/device-reachability-status-subscriptions.yaml
Outdated
Show resolved
Hide resolved
akoshunyadi
previously approved these changes
Jun 24, 2024
maxl2287
added
enhancement
|
The related Communality issue is closed. |
sachinvodafone
previously approved these changes
Jul 4, 2024
…e/cloud-event-when-delete-subscription # Conflicts: # code/API_definitions/device-reachability-status-subscriptions.yaml # code/API_definitions/device-roaming-status-subscriptions.yaml
maxl2287
dismissed stale reviews from sachinvodafone, bigludo7, and akoshunyadi
via
b9a48b3
akoshunyadi
approved these changes
Jul 12, 2024
sachinvodafone
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Adds a new termination-reason for "subscription-ends" - CloudEvent, when the user deletes the subscriptions via
DELETE /subscriptions/{subscriptionId}Which issue(s) this PR fixes:
Fixes #117