Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #139

Merged
merged 3 commits into from May 13, 2024
Merged

Update README.md #139

merged 3 commits into from May 13, 2024

Conversation

wrathwolf
Copy link
Contributor

Cleaned up README.md so that it is presentable for "GitHub Include" on the wiki

Also update community meeting registration / join link

Cleaned up README.md so that it is presentabile for "GitHub Include" on the wiki

Also update community meeting registration / join link
bigludo7
bigludo7 previously approved these changes Apr 12, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akoshunyadi
akoshunyadi previously approved these changes Apr 12, 2024
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@hdamker
Copy link
Contributor

hdamker commented Apr 12, 2024

Please comment in camaraproject/Template_Lead_Repository#3 regarding the upcoming structure for the README.md. That should be agreed before we touch all repositories.

sachinvodafone
sachinvodafone previously approved these changes Apr 29, 2024
@akoshunyadi
Copy link
Collaborator

@hdamker @wrathwolf Can we merge this PR? Are we conform with the agreed format?

@hdamker
Copy link
Contributor

hdamker commented May 8, 2024

@hdamker @wrathwolf Can we merge this PR? Are we conform with the agreed format?

@akoshunyadi not yet, see https://github.com/camaraproject/Template_Lead_Repository/blob/main/README.md. Let me propose the necessary changes later today.

@hdamker hdamker dismissed stale reviews from sachinvodafone, akoshunyadi, and bigludo7 via 16e59f1 May 8, 2024 08:52
Copy link

github-actions bot commented May 8, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 1 0 1.99s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.77s
✅ YAML yamllint 1 0 0.43s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@hdamker
Copy link
Contributor

hdamker commented May 8, 2024

@akoshunyadi I have updated the README according to the template (moved the release information back into an own section). Megalinter is failing on unchanged files, I suppose that the branch need to be rebased?

hdamker
hdamker previously approved these changes May 8, 2024
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now :-)

@akoshunyadi
Copy link
Collaborator

Don't we need the link to the meeting minutes?

Added meeting minutes & aligned mailing list lines with template.
@hdamker
Copy link
Contributor

hdamker commented May 9, 2024

Don't we need the link to the meeting minutes?

@akoshunyadi you are right, missed that line from the template. Added with efd99cb

(will leave approval and merge now to the Sub Project ... had approved before only to get my blocking comments out of the way)

@hdamker hdamker requested a review from akoshunyadi May 9, 2024 16:23
@akoshunyadi akoshunyadi merged commit dfbdcee into main May 13, 2024
1 check passed
@hdamker hdamker deleted the wrathwolf-patch-1 branch May 14, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants