-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/support subdomains #494
Conversation
…selectedCommunity
Ok @lucca65 apparently your community (I'm assuming it's happening with |
Damn, I really can't replicate this 😬. The way the app starts up right now is:
(By user information I mean the Can you check on the console if there is some logging that says you've been logged out? (It would probably be shown as |
Ok, I tried using a valid url now. Works well |
oh. sorry then bro, my bad, I should have checked it before hand. it won't happen again 💪 |
I must suppose then its something on Safari. I've tested it on Safari, Chrome and Firefox and it only happens on Safari consistently. Which is a problem because we must support Apple ecosystem, as it is almost 20% of our user base. We have a few alternatives:
Either way we need to support it bro ): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍬
@lucca65 Bad news on the safari support... After a lot of testing and digging, I stumbled upon this StackOverflow thread, which is pretty much exactly what we're trying to do. Safari introduced a security feature where we can't do this (with localStorage), as far as I understand. I've tried using The option introduced in the Storage Access API is to use cookies instead of localStorage, which I really don't like, but it seems to be our only option to support the latest safari releases 😬. What do you think we should do? |
damn... really? 😢 |
This is so bad, I needed a time to digest this. "Aos 45 do segundo tempo" 😩 Its bad that advertisers used this feature to fuck privacy up. Damn Well, we have no choice and we should be more attentive about Apple's ecosystem. Safari is the new Internet Explorer |
Should we try using cookies then? |
we have no other alternative, right? |
I don't think so 😩 |
yeah, I'll let the team know this is going to take longer yet ): |
@lucca65 everything should work now! We're using cookies, and moving all the localStorage data people might have to cookies as well, so they're not logged out as soon as the update is released. Also, if we want to keep sessions between communities when developing on localhost, we should use urls like |
What issue does this PR close
Addresses #495, closes #470
Changes Proposed ( a list of new changes introduced by this PR)
LoggedIn
0,CMB
) from URLsHow to test ( a list of instructions on how to test this PR)
muda.localhost:3000
) and seeing if the correct community is loaded. Try this with communities that:/community/new
), and see if it behaves as expected