Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error if account already exists #830

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

henriquecbuss
Copy link
Member

What issue does this PR close

Closes #821

Changes Proposed ( a list of new changes introduced by this PR)

  • Show error when account name already exists on register page (we already had this, but something broke it - likely Enhancement/forms #658)

How to test ( a list of instructions on how to test this PR)

  • Try to register with an account name that already exists (for example, the one from the issue: JujutestePtb)
  • See error

@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for cambiatus-elm-book ready!

Name Link
🔨 Latest commit 717ba91
🔍 Latest deploy log https://app.netlify.com/sites/cambiatus-elm-book/deploys/6317ffdea3ff3d0008ee3333
😎 Deploy Preview https://deploy-preview-830--cambiatus-elm-book.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy done!

Name Link
🔨 Latest commit 717ba91
🔍 Latest deploy log https://app.netlify.com/sites/cambiatus/deploys/6317ffdee2dd210008b37044
😎 Deploy Preview https://deploy-preview-830--cambiatus.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working!

@juramos-2020
Copy link

@NeoVier
Esse teste é para ser feito na criação de uma nova conta correto?
Eu estou usando a comunidade CCON pois a da Cambiatus não possui o link de criação de uma conta

"Ainda não tem uma conta? Crie agora"

O teste pode ser feito usando essa comunidade?

@juramos-2020
Copy link

A mensagem de erro deve aparecer no campo "nome do usuário" correto?

@henriquecbuss
Copy link
Member Author

Isso mesmo, Ju. Ainda não tinha sincronizado no staging, mas agora já pode testar no link que vc mandou (https://ccon.staging.cambiatus.io/register)

@juramos-2020
Copy link

Prontinho @NeoVier tudo funcionando conforme o esperado. 👌✅

@henriquecbuss henriquecbuss merged commit e9ca38c into master Sep 9, 2022
@henriquecbuss henriquecbuss deleted the fix/duplicate-user-feedback branch September 9, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback de erro na tela de login
3 participants