Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/reorder categories #833

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

henriquecbuss
Copy link
Member

What issue does this PR close

Closes #780

Changes Proposed ( a list of new changes introduced by this PR)

  • Fix category reordering by using the position field
  • Recalculate the trees on the frontend for optimistic updates

How to test ( a list of instructions on how to test this PR)

  • Go to the categories settings page
  • Try to reorder them by dragging and dropping, and by using the "move up" and "move down" buttons

Still Pending

@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy Preview for cambiatus-elm-book ready!

Name Link
🔨 Latest commit dea0e2e
🔍 Latest deploy log https://app.netlify.com/sites/cambiatus-elm-book/deploys/631aaf4912fdf100081ec926
😎 Deploy Preview https://deploy-preview-833--cambiatus-elm-book.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy done!

Name Link
🔨 Latest commit dea0e2e
🔍 Latest deploy log https://app.netlify.com/sites/cambiatus/deploys/631aaf49220f430009ea9ba5
😎 Deploy Preview https://deploy-preview-833--cambiatus.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow categories to be ordered properly
1 participant