Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a secondyr class option (for second-year reports). #54

Merged
merged 5 commits into from Oct 1, 2017
Merged

Added a secondyr class option (for second-year reports). #54

merged 5 commits into from Oct 1, 2017

Conversation

PetarV-
Copy link
Contributor

@PetarV- PetarV- commented Sep 25, 2017

Similarly to my last year's contribution, here I provide a secondyr class option (did not update README.md as it needs a link to a sample .pdf).

Aside from modifying the title page appropriately, I've found that for writing a second-year report it is useful to have an abstract (as by then, the research is already "fleshed-out").

@urbas
Copy link
Member

urbas commented Sep 29, 2017

Thanks a lot for the contribution, @PetarV- ! Could you please add an entry into the README.md file, explaining the secondyr option?

Also, could you add a test case for secondyr into the folder .circleci/tests. You can copy and modify the test for firstyr.

@PetarV-
Copy link
Contributor Author

PetarV- commented Sep 30, 2017

Done! (I've assumed the form of the example link to put in README.md, but otherwise I think everything checks out!)

@urbas
Copy link
Member

urbas commented Oct 1, 2017

The README and the PDF look good (here's the actual result of the build)! Thanks, @PetarV- !

@urbas urbas merged commit d5dd150 into cambridge:master Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants