Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heredoc support? #4

Closed
neezer opened this issue Aug 17, 2021 · 5 comments
Closed

Heredoc support? #4

neezer opened this issue Aug 17, 2021 · 5 comments

Comments

@neezer
Copy link

neezer commented Aug 17, 2021

Hi! Awesome work with this!

I know it's relatively hot-off-the-press, but could we get Docker Heredoc support?

@camdencheek
Copy link
Owner

Thanks for pointing that out! I saw heredocs were released, but forgot to ever follow up on it with the grammar.

I'll need to do a bit more looking into this. Basically, I think heredocs will break some assumptions the grammar currently has about command endings and what we can delegate to the nested shell grammar. If we can't delegate heredocs to the shell grammar, this will almost certainly require making an external scanner in C. I'm not particularly familiar with C, so this might be a longer-than-seemingly-necessary process, but I'll see what I can do 😄

@mmetc
Copy link

mmetc commented Jan 20, 2023

Hi, was there any progress on this?

If it's simpler, support for "COPY <<eot" with embedded files would be useful enough. No need for fancy grammars inside the doc

thanks

@smason
Copy link

smason commented Jul 25, 2023

I'm also interested in know what happened to this!

I've written quite a bit of C code in my time, so could help out if you point me in the right direction. I've never done much with tree-sitter so don't know where to get started.

@camdencheek
Copy link
Owner

Thanks to @tvrinssen, this long-standing gap has finally been fixed in #45!

@danihodovic
Copy link

danihodovic commented Apr 19, 2024

Awesome! Thank you @tvrinssen & @camdencheek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants