-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: babyagi agent support #243
Conversation
Thanks, @hychen-naza. But it seems the PR is outdated from the master. Should we add the new changes by branching from the current master branch? |
I was branching from the master branch. The demo video is the one I shared few days ago. Small issue: I notice I have to specify the chat window size and task history size to avoid max token error. Let me know if you think if it's good or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good. Small changes requested.
camel/societies/babyagi_playing.py
Outdated
self.task_prompt, | ||
meta_dict=task_specify_meta_dict, | ||
) | ||
self.task_prompt = self.specified_task_prompt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overwriting self.task_prompt does not seem right. Why do we need self.specified_task_prompt then?
Please avoid mutation of fields. Also initialize a field only in one method. Both self.task_prompt and self.specified_task_prompt must be initialized in one method: init_specified_task_prompt in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comments.
I noticed the self.specified_task_prompt would lead to more concrete task planning and better task execution result. Otherwise, the user-input task prompt is too high-level to get useful results.
And, I avoid overwriting the self.task_prompt and initialize self.specified_task_prompt in init_specified_task_prompt method.
Thanks for the PR @hychen-naza. Part of the PR is outdated with the current master in |
Yeah, I am gonna fix the file conflicts and other comments proposed. |
I notice some tests in test_search_functions.py are failed, may need to check that tests. They are passed last night, so I guess they might fail with some probabilities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hychen-naza. That is an elegant implementation of BabyAGI
with CAMEL
!
It looks good overall. Left some minor comments.
@hychen-naza Are you working on this PR? Comments by @lightaime did not get addressed. I think we can merge this for 0.2 release. But the PR has to be finished first. You did a great job and it would be a shame if it does not make its way tho the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve all conversations before asking for a code review.
I know my response is late.. I fixed most of the comments and left some feedback. And lmk if you have any other comments or suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! I approve, but please wait for the approval by @lightaime before merging.
Thanks for the PR @hychen-naza! |
Description
Build Babyagi by composing chat agent (task solver) and task agent (task planner)
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Implemented Tasks
Checklist