-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate the roles and role description #247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feature. Let's polish it and have good code coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I think all the with_role_description
flags should be removed and just create new ASSISTANT_PROMPT
and USER_PROMPT
prompts with role_description in it.
Co-authored-by: Guohao Li <lightaime@gmail.com>
…/camel into feature/role-generation
Co-authored-by: Guohao Li <lightaime@gmail.com>
Co-authored-by: Guohao Li <lightaime@gmail.com>
Co-authored-by: Guohao Li <lightaime@gmail.com>
Co-authored-by: Guohao Li <lightaime@gmail.com>
Co-authored-by: zhiyu-01 <121875294+zhiyu-01@users.noreply.github.com> Co-authored-by: Guohao Li <lightaime@gmail.com> Co-authored-by: MorphlingEd <s1973609@ed.ac.uk> Co-authored-by: Tianqi Xu <40522713+dandansamax@users.noreply.github.com> Co-authored-by: Wenxuan Li <55635778+MorphlingEd@users.noreply.github.com>
Co-authored-by: zhiyu-01 <121875294+zhiyu-01@users.noreply.github.com> Co-authored-by: Guohao Li <lightaime@gmail.com> Co-authored-by: MorphlingEd <s1973609@ed.ac.uk> Co-authored-by: Tianqi Xu <40522713+dandansamax@users.noreply.github.com> Co-authored-by: Wenxuan Li <55635778+MorphlingEd@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Appointat. This is very cool. Left some comments. Let me know if there is any question!
def test_role_generation_example(): | ||
with patch('time.sleep', return_value=None): | ||
examples.role_description.role_generation.main(ModelType.GPT_3_5_TURBO) | ||
|
||
|
||
def test_role_playing_with_role_description_example(): | ||
with patch('time.sleep', return_value=None): | ||
examples.role_description.role_playing_with_role_description.main( | ||
ModelType.GPT_3_5_TURBO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing these two examples with ModelType.GPT_3_5_TURBO
is too slow and expensive. Should we just patch the return and test them with ModelType.STUB
?
ai_assistant_role = role_names[AI_ASSISTANT_ROLE_INDEX] | ||
ai_user_role = role_names[AI_USER_ROLE_INDEX] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we know which is the assistant role and which is the user role?
Co-authored-by: Guohao Li <lightaime@gmail.com>
Co-authored-by: Guohao Li <lightaime@gmail.com>
…/camel into feature/role-generation
Co-authored-by: Guohao Li <lightaime@gmail.com>
Thanks @Appointat @ZhangT-tech for adding this awesome future!! |
Description
Note: Due to GitHub's security constraints, secret keys are inaccessible in CI/CD workflows for PRs raised from the fork. This is to safeguard sensitive information. To address this and ensure the workflows run correctly, I created a new branch, "feature/role-generation", directly under the original project and raised this PR from there. The previous PR #240 from the fork will be closed to avoid confusion.
Describe your changes in detail.
Motivation and Context
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
Output of the new example