-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add web search #274
Merged
feat: add web search #274
Changes from 26 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
fd98180
add web search
zhiyu-01 a19aba2
update
zhiyu-01 ce8a4a6
update
zhiyu-01 1ce288b
Merge branch 'master' into function
zhiyu-01 c593ad3
Merge branch 'master' into function
zhiyu-01 7f8450d
Update web_search.py
zhiyu-01 5193c01
Merge branch 'master' into function
zhiyu-01 1f75055
Merge branch 'master' into function
zhiyu-01 591fa47
update
zhiyu-01 a882e26
Merge branch 'function' of https://github.com/camel-ai/camel into fun…
zhiyu-01 5f16411
Update web_search.py
zhiyu-01 b224c1d
Merge branch 'master' into function
zhiyu-01 9ecb3e4
Update camel/functions/web_search.py
zhiyu-01 51d9ca2
Update camel/functions/web_search.py
zhiyu-01 1cf40ff
Update camel/functions/web_search.py
zhiyu-01 f3f65dc
Update camel/functions/web_search.py
zhiyu-01 e8ba969
update
zhiyu-01 48515fc
update
zhiyu-01 eb9521c
update
zhiyu-01 f48f46c
Merge branch 'master' into function
zhiyu-01 25590ba
update
zhiyu-01 6444d85
Merge branch 'function' of https://github.com/camel-ai/camel into fun…
zhiyu-01 13a3bb8
update
zhiyu-01 70c6ef6
update
zhiyu-01 685e7d4
update
zhiyu-01 a7d8dbe
Update search_functions.py
zhiyu-01 a9435b2
update
zhiyu-01 5c826ba
Update chat_agent.py
zhiyu-01 db92799
update
zhiyu-01 4fc33f7
Merge branch 'master' into function
zhiyu-01 84f032c
update
zhiyu-01 a14213f
Merge branch 'function' of https://github.com/camel-ai/camel into fun…
zhiyu-01 3e2514c
Update test_role_playing.py
zhiyu-01 2f0dc19
update
zhiyu-01 6d9b1eb
Merge branch 'master' into function
lightaime File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -294,7 +294,8 @@ def step( | |
a boolean indicating whether the chat session has terminated, | ||
and information about the chat session. | ||
""" | ||
messages = self.update_messages('user', input_message) | ||
messages = self.update_messages(input_message.role_type.value, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
zhiyu-01 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
input_message) | ||
|
||
output_messages: List[BaseMessage] | ||
info: Dict[str, Any] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we had this bug in the code, please add to the test of
ai_society\role_playing.py
a check of the sequence of roles:or whatever it must be. I expect added checks in
test/agents/test_role_playing.py
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait a second. I recall figuring out this complex behavior of changing the roles. I even put an explicit comment:
also see the doctoring above:
Please let me know if you think this is in the scope of this change or not. If not, make a separate bug ticket and a separate PR with the proper fix and the test, and revert the irrelevant changes in thin PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait. I don't think this is a bug.