Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(memory): chat history memory support #280

Merged
merged 87 commits into from
Nov 5, 2023
Merged

Conversation

dandansamax
Copy link
Collaborator

Description

Add ChatHistoryMemory support for ChatAgent.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@dandansamax dandansamax mentioned this pull request Sep 6, 2023
9 tasks
Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is awesome!! Thanks for the PR. Sorry for the late review. Leave some comments.

camel/agents/chat_agent.py Show resolved Hide resolved
camel/agents/chat_agent.py Outdated Show resolved Hide resolved
camel/agents/chat_agent.py Outdated Show resolved Hide resolved
camel/agents/chat_agent.py Outdated Show resolved Hide resolved
camel/agents/chat_agent.py Outdated Show resolved Hide resolved
camel/typing.py Show resolved Hide resolved
camel/typing.py Outdated Show resolved Hide resolved
test/memory/test_chat_history_memory.py Outdated Show resolved Hide resolved
test/memory/test_context_creator.py Outdated Show resolved Hide resolved
test/storage/test_dict_storage.py Outdated Show resolved Hide resolved
Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Great work! @dandansamax

camel/memories/__init__.py Outdated Show resolved Hide resolved
camel/agents/chat_agent.py Outdated Show resolved Hide resolved
camel/memories/base.py Outdated Show resolved Hide resolved
camel/memories/__init__.py Outdated Show resolved Hide resolved
camel/memories/chat_history_memory.py Outdated Show resolved Hide resolved
camel/memories/chat_history_memory.py Outdated Show resolved Hide resolved
camel/memories/chat_history_memory.py Outdated Show resolved Hide resolved
camel/memories/context_creators/base.py Outdated Show resolved Hide resolved
camel/memories/context_creators/base.py Outdated Show resolved Hide resolved
camel/storages/key_value_storages/json.py Outdated Show resolved Hide resolved
@lightaime lightaime merged commit da517a8 into master Nov 5, 2023
8 checks passed
@lightaime lightaime deleted the chat_history_memory branch November 5, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants