-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update role_playing_with_function.py #414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zhiyu-01. Thanks for the PR. But why we can the user agent has access to the tools here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your consideration about the function call. There is one comment.
function_list = [*MATH_FUNCS, *SEARCH_FUNCS, *WEATHER_FUNCS] | ||
user_model_config = FunctionCallingConfig.from_openai_function_list( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zhiyu-01 , still working on the PR? If yes:
- Please update the branch and fix the ci/cd
- I got your point, you would like to let the user provide better instructions to the assistant about the weather search. However, if you configure it like this, which means that the user can also use the weather API to search for the weather, it does not conform to the user's role setting.
- In addition, if you still want to improve it, there is another approach: you can create/add the role description for the user. Here is an example about the role description:
https://github.com/camel-ai/camel/blob/master/examples/role_description/role_playing_with_role_description.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will try the role description.
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Description
In role playing with function call, give the user agent the information about function can allow user to instruct the assistant agent to use which function, and the confuse phenomenon also has disapeared.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213
if this solves the issue #15213Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!