added more tests for YAML DSL (using a schema) #364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
completion called at the right place Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
lhein
commented
Jul 8, 2020
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
lhein
commented
Jul 8, 2020
| @@ -5,9 +5,9 @@ | |||
| uri: "timer:tick" | |||
| parameters: | |||
| period: "5s" | |||
| steps: | |||
There was a problem hiding this comment.
this change was required because the yaml structure changed
…yaml file Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
apupier
requested changes
Jul 8, 2020
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
apupier
reviewed
Jul 9, 2020
|
|
||
| export const updateSettings = (setting: any, value: any) => { | ||
| const yamlConfiguration = vscode.workspace.getConfiguration('yaml'); | ||
| return yamlConfiguration.update(setting, value, false); |
|
|
||
| export const resetSettings = (setting: any, value: any) => { | ||
| const yamlConfiguration = vscode.workspace.getConfiguration('yaml'); | ||
| return yamlConfiguration.update(setting, value, false); |
| const expect = chai.expect; | ||
|
|
||
| describe('YAML DSL and endpoint uri completion tests backed by schema', () => { | ||
| const yamlSchemaUri: vscode.Uri = vscode.Uri.parse('https://raw.githubusercontent.com/lburgazzoli/apache-camel-k-runtime/github-358/camel-k-loader-yaml/camel-k-loader-yaml/src/generated/resources/yaml-schema.json'); |
There was a problem hiding this comment.
it wasn't available when the PR was written but now that it is on master, maybe better to point to https://github.com/apache/camel-k-runtime/blob/master/camel-k-loader-yaml/camel-k-loader-yaml/src/generated/resources/camel-yaml-dsl.json
that said, it migth be worthy to wait for the schemastore to be available and rely on it SchemaStore/schemastore#1138 (or can be done in another iteration)
There was a problem hiding this comment.
it is now available on schemastore so it can be completely removed
|
closing as it has not been touched for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request informations
Rebase & Merge default requirements
PR labels default process
Tests
PR workflow progress