Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #311 - shifting to kamel log instead of kubectl log #313

Merged
merged 2 commits into from
Feb 20, 2020
Merged

issue #311 - shifting to kamel log instead of kubectl log #313

merged 2 commits into from
Feb 20, 2020

Conversation

bfitzpat
Copy link
Contributor

Signed-off-by: bfitzpat@redhat.com <bfitzpat@redhat.com>
@bfitzpat
Copy link
Contributor Author

Switching to kamel log [integration] instead of kubectl logs-f [podname] gives us uninterrupted coverage of the running integration, including when the integration is re-deployed with changes. The issue was that using kubectl required us to follow a single pod, which is then discarded when an integration is re-published. The kamel version follows the integration through shutting down a running pod and spinning a new one up.

The only problem I have found is a complete lack of log feedback when the kit is created and the pod is first spinning up. There is just... nothing. Without any kind of user feedback, some users may wonder if the integration will ever spin up.

I have asked for an update in apache/camel-k#1283 so that the user can see something moving while waiting for the integration to start. Running kamel log [integration] at the command line has the same problem.

Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great.

I have some questions that I put in comment.

(I miss test :'-()

src/kubectlutils.ts Outdated Show resolved Hide resolved
src/logsWebview.ts Show resolved Hide resolved
Signed-off-by: bfitzpat@redhat.com <bfitzpat@redhat.com>
@bfitzpat bfitzpat merged commit d716252 into camel-tooling:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants