Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing to include the same file twice - fix #1 #2

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Allowing to include the same file twice - fix #1 #2

merged 1 commit into from
Dec 12, 2017

Conversation

Lucas-C
Copy link
Contributor

@Lucas-C Lucas-C commented Dec 11, 2017

No description provided.

@camelaissani
Copy link
Owner

The build failed because node runtime was to old. Some dev dependencies use es6 syntax which is badly supported by node v0.10 😄
I just fixed this.
Could you update your fork and submit again your PR?
I'll appreciate if you can move your testcase in the "right workflows" block (https://github.com/camelaissani/markdown-it-include/blob/master/test/default.js#L10)

@Lucas-C
Copy link
Contributor Author

Lucas-C commented Dec 12, 2017

Done !

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9ed64d4 on Lucas-C:master into 533c7e5 on camelaissani:master.

@camelaissani camelaissani merged commit 81f3440 into camelaissani:master Dec 12, 2017
@camelaissani
Copy link
Owner

Thanks for your contribution. I'm gonna make a new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lucas-C @camelaissani @coveralls