Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] add DataFrame to_excel params, requirements.txt XlsxWriter>=0.9.8 #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xubiuit
Copy link

@xubiuit xubiuit commented May 5, 2020

Hi guys,

Basically camelot is using pandas.DataFrame.to_excel to export excel file.
But it seems there are 2 available options sheet_name, encoding are supported, the idea is follow the

layout_kwargs={},

then I've create new df_kwargs which is used for df.to_excel.

While using export feature, I also faced issue with minimum version of XlsxWriter is 0.9.8, then I've just added to this commit.

Regards,

@vinayak-mehta vinayak-mehta added this to Backlog in TODO! Jul 9, 2020
Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@MartinThoma
Copy link
Contributor

Hey!

As camelot is dead, we try to build a maintained fork at pypdf_table_extraction.

Do you want to open the PR against that branch so that we can merge your improvement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
TODO!
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants