MAINT: Replace PyPDF2 by pypdf #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinThoma
force-pushed
the
pypdf2-update
branch
from
5b8d694
to
3e51727
Compare
|
Why has this not been merged into main (master) yet? |
sanecz
added a commit
to sanecz/python-msr-doc
that referenced
this pull request
Jan 2, 2023
Until camelot-dev/camelot#307 is merged
hubutui
reviewed
Jan 4, 2023
hubutui
reviewed
Jan 4, 2023
|
@dimitern Can you merge this PR? |
|
Can this PR be merged please? |
|
I'm also hoping this gets merged soon! |
|
@dimitern I've seen that this wasn't released so far https://pypi.org/project/camelot-py/#history - do you happen to know when it will be released? |
|
I'm releasing it right now, sorry for the late reply here |
|
@MT-Cash the release is now live: https://pypi.org/project/camelot-py/ Thank you for the PR! |
MartinThoma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyPDF2 changed the syntax and deprecated Python 3.5 and older. As camelot requirest 3.6 or newer, there is no reason not to upgrade.
Fixes #339