Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed calling convention of callback functions #34

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Fixed calling convention of callback functions #34

merged 1 commit into from
Jul 24, 2019

Conversation

KOLANICH
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   87.69%   87.69%           
=======================================
  Files          13       13           
  Lines        1511     1511           
  Branches      349      349           
=======================================
  Hits         1325     1325           
  Misses        129      129           
  Partials       57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b94b3...5687fbc. Read the comment docs.

@KOLANICH
Copy link
Contributor Author

@vinayak-mehta

@vinayak-mehta
Copy link
Member

vinayak-mehta commented Jul 22, 2019 •
edited
Loading

Please give me some time to check this out. 👍

dimitern
dimitern approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@dimitern dimitern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to fix this!

@dimitern dimitern merged commit b2929a9 into camelot-dev:master Jul 24, 2019
@KOLANICH KOLANICH deleted the win_ghostscript_callback_fix branch July 24, 2019 12:26
@vinayak-mehta
Copy link
Member

@KOLANICH Thanks for the PR! @dimitern Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitern dimitern dimitern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KOLANICH @codecov-io @vinayak-mehta @dimitern