Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] "Be Cordial or Be on Your Way" and Camelot Project PDF not Working #366

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

kshitiz305
Copy link
Contributor

hyperlinks to Kenneth Reitz' essay in CODE_OF_CONDUCT.md and CONTRIBUTING.md are dead along with Camelot Project PDF showing ads

Issue: #364
Link: #364

Signed-off-by: Kshitiz Gupta kshitiz305@live.com

hyperlinks to Kenneth Reitz' essay in CODE_OF_CONDUCT.md and CONTRIBUTING.md are dead along with Camelot Project PDF showing ads

Issue:364

Signed-off-by:Kshitiz Gupta <kshitiz305@live.com>
@kshitiz305
Copy link
Contributor Author

The changes are related to the links in the documentation thus the success of the test is not quite important

@kshitiz305
Copy link
Contributor Author

@johnnymetz @christinegarcia @vinayak-mehta

Whenever you are free kindly have a look on this PR as it is related to the documentation hyperlink changes and should be quick as the passing of the test should not be affected by it.

@foarsitter foarsitter merged commit e8defec into camelot-dev:master Jul 14, 2023
1 of 5 checks passed
@foarsitter
Copy link
Contributor

Thanks @kshitiz305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants