[MRG] Fixed strip_text argument getting ignored #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitern
changed the title
This was referenced Jul 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
==========================================
+ Coverage 87.64% 87.69% +0.04%
==========================================
Files 13 13
Lines 1505 1511 +6
Branches 348 349 +1
==========================================
+ Hits 1319 1325 +6
Misses 129 129
Partials 57 57
Continue to review full report at Codecov.
|
tomprogrammer
pushed a commit
to tomprogrammer/camelot
that referenced
this pull request
May 10, 2023
…in() ValueError: min() arg is an empty sequence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've discovered the strip_text argument to read_pdf() seems to be silently ignored.
There is a test for it, but it's not really testing the stripping logic.
I've prepared a PR to fix the issue.