Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-load dotenv to properly load db env variables #186

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

benpbolton
Copy link
Contributor

Minor update to README for UX.

Description

Adding a NODE_OPTIONS preface to the command to pre-load dotenv

Motivation and Context

When a user specifies custom database parameters in .env, these are not currently loaded during an npm run db:migrate. Pre-loading dotenv through the NODE_OPTIONS is a low-lift one-line option to assist someone walking step-by-step through the instructions.

How Has This Been Tested?

Personal experience:)

Screenshots (if appropriate):

Screen Shot 2023-02-08 at 5 17 10 PM

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@benpbolton
Copy link
Contributor Author

Happy to close this if it's undesirable to leverage the existing dotenv stuffs, even the npm run start standalone instruction could potentially benefit from this.

@cameri
Copy link
Owner

cameri commented Feb 10, 2023

Hi thanks for your contribution!
Could you please update your commit message so it complies with Conventional Commits? it's failing because it's missing a prefix: https://www.conventionalcommits.org/en/v1.0.0/#summary

@cameri cameri merged commit b559ffb into cameri:main Feb 17, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.22.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

brandonrobinson5060 pushed a commit to VIDA-Global/nostream that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants