Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for showing absolute ETA #188

Merged
merged 10 commits into from
May 24, 2021
Merged

Conversation

mmirate
Copy link
Contributor

@mmirate mmirate commented May 13, 2021

i.e. instead of the estimated amount of time remaining in the print, this is the datetime at which the print is estimated to finish.

Also, while I was at it, I put the status-embed's filename field inside backticks, so that filenames containing double underscores don't get mangled by Discord's Markdown interpretation.

cameroncros and others added 10 commits December 21, 2020 13:28
Added instructions for finding the correct User ID
Clarifying a couple points and linking to a list of commands in the wiki.
i.e. instead of the estimated amount of time remaining in the print,
this is the datetime at which the print is estimated to finish.
@mmirate
Copy link
Contributor Author

mmirate commented May 13, 2021

ERROR: Package 'rsa' requires a different Python: 2.7.17 not in '>=3.5, <4'

<snip>

___________________________________ summary ____________________________________
ERROR:   py27: could not install deps [git+https://github.com/foosel/OctoPrint.git@1.3.12, -rrequirements.txt, -rrequirements-dev.txt]; v = InvocationError('/root/repo/.tox/py27/bin/python -m pip install git+https://github.com/foosel/OctoPrint.git@1.3.12 -rrequirements.txt -rrequirements-dev.txt', 1)
  py37: commands succeeded

FYI, your CI appears to have some pre-existing problems. Though, since Python 2 has been unsupported for quite awhile by Octoprint (let alone by the Python upstream themselves), I think this is trivially fixable by removing Python 2 from this project's testing matrix.

@cameroncros
Copy link
Owner

cameroncros commented May 14, 2021 via email

@cameroncros cameroncros changed the base branch from master to dev May 24, 2021 03:27
@cameroncros cameroncros merged commit 3f83e08 into cameroncros:dev May 24, 2021
@cameroncros
Copy link
Owner

Sorry for the delay, but I have now merged this. Thank you for your contribution.

@mmirate mmirate deleted the eta branch May 24, 2021 11:49
@mmirate
Copy link
Contributor Author

mmirate commented May 24, 2021

You're welcome! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants