-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for showing absolute ETA #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added instructions for finding the correct User ID
Update README.md
Clarifying a couple points and linking to a list of commands in the wiki.
Update README.md
i.e. instead of the estimated amount of time remaining in the print, this is the datetime at which the print is estimated to finish.
FYI, your CI appears to have some pre-existing problems. Though, since Python 2 has been unsupported for quite awhile by Octoprint (let alone by the Python upstream themselves), I think this is trivially fixable by removing Python 2 from this project's testing matrix. |
Yup, the py27 testing is pretty much pointless, will remove in the future.
I will try review this PR soon, thanks for the contribution.
…On Fri, 14 May 2021, 8:03 am Milo Mirate, ***@***.***> wrote:
___________________________________ summary ____________________________________
ERROR: py27: could not install deps ***@***.***, -rrequirements.txt, -rrequirements-dev.txt]; v = InvocationError('/root/repo/.tox/py27/bin/python -m pip install ***@***.*** -rrequirements.txt -rrequirements-dev.txt', 1)
py37: commands succeeded
FYI, your CI appears to have some pre-existing problems. Though, since
Python 2 has been unsupported for awhile by Octoprint (let alone by the
Python upstream themselves), I think this is trivially fixable by removing
Python 2 from this project's testing matrix.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#188 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAK7FL5ETCW23B7R3ECU6ELTNRECJANCNFSM44ZV7ZVA>
.
|
cameroncros
approved these changes
May 24, 2021
Sorry for the delay, but I have now merged this. Thank you for your contribution. |
You're welcome! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. instead of the estimated amount of time remaining in the print, this is the datetime at which the print is estimated to finish.
Also, while I was at it, I put the status-embed's filename field inside backticks, so that filenames containing double underscores don't get mangled by Discord's Markdown interpretation.