Fix for queue once lock key not being deleted properly #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems: redis lacks flush
When running QueueOnce subclass task, I noticed the lock key never got deleted, event though QueueOnce.after_return was called and issued
self.once_backend.clear_lock(key)
.After examining it turned out that I had to add
self.redis.flushall()
toclear_lock(key)
for key to be cleared properly.Here are my libs versions:
In this pull request I added redis.flushall() after lock delete request, which solves the issue.