remove require_all dependency and move formula code under odyssey module #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes explicit _is_ better than implicit.
jethrodaniel
changed the title
require-all dependency
jethrodaniel
changed the title
Noticed that we're adding `Formula` into the top-level namespace, which is pretty bad practice, so I went ahead and moved all the formula code under `lib/odyssey`, and wrapped it in the odyssey module, like a typical gem.
jethrodaniel
changed the title
cameronsutter
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always nice to have no dependencies.
Noticed that we're adding
Formulainto the top-level namespace, which is prettybad practice, so I went ahead and moved all the formula code under
lib/odyssey,and wrapped it in the odyssey module, like a typical gem.