Better spec data #32
Closed
Better spec data #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes all the hard coding from the specs, and puts the text metrics and scores with the texts themselves. adds activesupport dev dependency, to symbolize the yaml keys the lazy way.
|
What'd I'd really like to do here is to have this gem tested against the same fixtures that other libraries of this sort use. Ideally, all the yaml fixtures would get migrated out to a single repo, which would be more useful for more people. Closing this as such. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some spec data (copyright free), and updates the specs.
Removes all of the
shouldsyntax in our specs, and replaces them with the more common/modern/supportedexpectsyntax.Moves all the hardcoded values from the specs into the texts themselves, which are in yaml.
As referenced in #24 (comment)
Resolves #23