Fix cache / DB sync issue with primary domains #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue found in the new unit tests by rearranging the logic for primary domains to ensure both the database and cache stay in sync.
Namely, the cache handling is mostly moved to
DarkMatter_Domains
instead ofDarkMatter_Primary
by ensuring the "updates" for domains are managed in a single place. This also removes some duplicate database logic that was missed in previous iterations of the plugin since version 2.0.0.Resolves the two unit test errors:
Fixes: #93