Add safe buffer subclass which handles arrays #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camertron
requested changes
Jun 11, 2021
| @@ -0,0 +1,13 @@ | |||
| require 'rux' | |||
There was a problem hiding this comment.
Probably not…I noticed you had requires in some of the other files so I added it for consistency.
It would appear not. Rux is handling things a bit differently than traditional ERB so I'm not surprised they're only thinking in terms of string expressions. |
|
Published in v1.1.0 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This echoes similar work done to resolve camertron/rux#2.
I haven't actually tested this yet with Rails…basically just copied over work I did to get the safe buffer working in Bridgetown. If you can think of a more elegant solution, let me know!