Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve lookup generation #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve lookup generation #7

wants to merge 1 commit into from

Conversation

AlexHill
Copy link
Contributor

This also adds Django's year lookup optimisations to NaiveDateTimeFields, and support for all current datetime Extract and Trunc types.

@AlexHill
Improve lookup generation
b54e4e1 
This also adds Django's year lookup optimisations to NaiveDateTimeFields, and support for all current datetime Extract and Trunc types.
camflan
camflan approved these changes Apr 29, 2021
View reviewed changes
Copy link
Owner

@camflan camflan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice improvement here. Would you mind adding some documentation in the README for settings.NAIVEDATETIMEFIELD_MONKEYPATCHING and it's use cases?

@AlexHill
Copy link
Contributor Author

I'll add a bit more test around the monkeypatching stuff too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camflan camflan camflan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexHill @camflan