Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValInteger should not have an annotation #16

Closed
madgen opened this issue May 30, 2016 · 1 comment
Closed

ValInteger should not have an annotation #16

madgen opened this issue May 30, 2016 · 1 comment
Assignees
@mrd
Labels
Type: Enhancement

Comments

@madgen
Copy link
Member

madgen commented May 30, 2016

Value nodes are meat to be embedded in ExpValue at all times, hence none of them need annotation. Enclosing expressions should have the annotations.

At some point @mrd changed this for ValVariable (I believe for renaming), it would be nice if we go back to original design as right now all captures/generations of ValIntegers end up copying the same annotation for ValVariable and its enclosing ExpValue.
@mrd mrd closed this as completed Jun 2, 2016
@mrd
Copy link
Collaborator

mrd commented Jun 2, 2016

in commit c3eea28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrd mrd

Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrd @madgen