Various minor cleanups + adding GitHub Actions CI (no coverage yet) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `-Wno-c99-extensions` because we use `_Bool` (via `bool`). - Added some missing `break`s in switch statements. - Made the error string array `static`. - Corrected treatment of `WORDS_BIGENDIAN` to be in accordance with the readme, which says if you don't set it, we default to runtime detection (which compilers actually optimise out).
|
This all looks great! Thanks so much for sending this upstream 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all the changes I've had to make to get things to compile when submoduled
into https://github.com/TokTok/c-toxcore. Since cmp isn't a library that gets installed,
it is compiled with the same strict compiler flags as the rest of the code.
Feel free to cherry-pick commits or do things differently. I'll be maintaining my fork
until upstream compiles with all the warning flags we use.