Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying read timeout #11

Merged
merged 6 commits into from
Jul 15, 2014
Merged

Conversation

tyro89
Copy link
Contributor

@tyro89 tyro89 commented Jul 15, 2014

Added support for :read_timeout config as specified in https://github.com/wvanbergen/vertica/blob/master/lib/vertica/connection.rb#L23

@camilo

@@ -34,7 +34,8 @@ def connect(server)
:port => opts[:port],
:schema => opts[:schema],
:database => opts[:database],
:ssl => opts[:ssl]
:read_timeout => opts[:read_timeout],
:ssl => opts[:ssl]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just gets passed to the vertica gem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is part of the initialization of ::Vertica::Connection.new :)

@camilo
Copy link
Owner

camilo commented Jul 15, 2014

once ci is happy 🐑

camilo pushed a commit that referenced this pull request Jul 15, 2014
Add support for specifying read timeout
@camilo camilo merged commit 9e4bdef into camilo:master Jul 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants