Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for ILIKE and NOT ILIKE operators #15

Merged
merged 1 commit into from
Sep 14, 2016

Conversation

brendanstennett
Copy link

Sometimes Vertica complains about UPPER(str) LIKE UPPER('%str%') when comparing longer strings. Vertica does however support ILIKE just like PostgreSQL and does not complain when comparing longer strings.

This PR adds support for ILIKE and NOT ILIKE

@brendanstennett
Copy link
Author

Travis failed but it looks like it was actually a test setup problem for 1.9.3 and nothing to do with running the tests at all.

Also note that this implementation is taken directly out of sequel itself in the way that this is implemented for PostgreSQL.

https://github.com/jeremyevans/sequel/blob/master/lib/sequel/adapters/shared/postgres.rb#L1253

@camilo
Copy link
Owner

camilo commented Sep 13, 2016

LGTM but conflicts with another patch

@brendanstennett
Copy link
Author

Rebased.

@camilo camilo merged commit 3b2ad43 into camilo:master Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants