Update To Support Sequel 4.49+ #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emschwar
changed the title
* Support COPY FROM STDIN ... with #copy_into (based on the Sequel postgres adapter) * Required updating vertica to 1.0 for best support with the driver' #copy method. * New driver returns Vertica::Row objects, which required an update to #fetch_rows in order to convert them back to symbol-keyed Hashes. * New driver does not support :schema as a connection option, so removed it. * Added Dataset#complex_expression_sql_append to convert operators ~ and ~* to use REGEXP_LIKE with options
As of Sequel 4.49 (starting probably somewhat earlier in the 4.x series), adapters appear to be expected to populate the columns cache (by setting self.columns) in the Dataset's fetch_rows() method. This change conforms to that expectation, and also removes the sequel-vertica adapter's own cache of column attributes.
JakPhu-tt
force-pushed
the
fix_sequel_deprecations
branch
from
fd3dfe9
to
4e46aa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates sequel-vertica to be compliant with recent Sequel versions as of 4.49.
adapters appear to be expected to populate the columns cache (by setting
self.columns) in the Dataset's fetch_rows() method. This change conforms
to that expectation, and also removes the sequel-vertica adapter's own
cache of column attributes.
__(double underscores) to separate schemas and tables (and columns)is deprecated; use
Sequel[]instead.log_yieldis deprecated in favor oflog_connection_yield#dataset_class_defaultmethod to define which class touse for a dataset, instead of relying on the framework to call
const_get("Dataset")for us.with their previous values.
Sequel.cache_anonymous_modelshas been moved toSequel::Model