Use tirpc as RPC implementation if available #47
Conversation
Glib has recently removed its RPC headers, and it is advised to use tirpc instead. This patch simply switches to tirpc if available on the system.
|
Good morning Simon and thanks for the patches. |
|
Hi Simon, Thanks again for the patches and for making the compilation work again! Unfortunately some first tests seem to show, as pointed by @calderonth, that something goes wrong during RPC as the proxy is killed and restarted during the first request. We will have to investigate this a bit more to fix the issue. Small update: installing tirpc on an ubuntu 18.04 and compiling with the PR works, while there are some issues on debian (at least on my 'unstable' release). Regards, |
|
Allright, no worries. I haven't shipped the patches yet, I was waiting
for your feedback, as I don't know the software enough to be able to
judge beyond the "does it build and pass tests?" step :). Looks like it
was the right call. Give me a nudge if I can do something to help!
|
|
Hi Simon, Thanks for the help proposal :-) A quick update after some further investigation: the issue under Debian unstable and recent versions of OCaml seems to lie in the IDL generation layer that provokes a "late segfault" during RPC in the server process. We will try to understand where is the exact hiccup with IDL, hopefully fix it, and then deal with merging your PR. Regards, |
|
This should be fixed in branch https://github.com/caml-pkcs11/caml-crush/tree/rbe/fix_release with the two PRs #46 and #47 merged and tested. The compatibility with OCaml < 4.02 should be back with the last commit 549542b. We will take time to perform some tests with @calderonth and will merge all this if all is OK :-) Regards, |
This PR addresses includes the changes provided in #46 and #47 but add the necessary logic to have the Caml Crush code compatible with TIRPC has some implementation details had changed. In addition, this introduces a way to perform end-to-end testing using docker-compose and should allow for better future-proofing and better backward compatibility testing. * Port the code to use safe strings only * build: Remove the unsafe-strings flag * Use tirpc as RPC implementation if available * Fix generated IDL patch with recent versions of camlidl as some functions renaming prevent spatch (coccinelle) from performing its semantic patch on the pkcs11_stub.c * Put back compatibility with OCaml < 4.02 where the Bytes module is not present. This is achieved through preprocessing. * Refresh IDL and RPC generated headers and files with more recent versions of camlidl and rpcgen. This can be useful for people who do not want to activate --with-idlgen and/or --with-rpcgen. * Initial integration tests using Docker * Implement tirpc fixes for OpenSSL * Propagate the binding patches to the standalone mode. * Add UNIX socket integration tests and more tirpc fixes Co-authored-by: Simon Chopin <simon.chopin@canonical.com> Co-authored-by: Ryad Benadjila <ryadbenadjila@gmail.com>
Glib has recently removed its RPC headers, and it is advised to use
tirpc instead. This patch simply switches to tirpc if available on the system.
I plan to ship this patch in Ubuntu and Debian to resolve build issues with their latest glibc updates.