Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redwood leaves don't use color providers. #28

Closed
LambdAurora opened this issue Jun 9, 2021 · 5 comments · Fixed by #29
Closed

Redwood leaves don't use color providers. #28

LambdAurora opened this issue Jun 9, 2021 · 5 comments · Fixed by #29
Labels
bug Something isn't working verified

Comments

@LambdAurora
Copy link

Describe the bug
Redwood leaves don't use color providers for the block form nor the item form.

Expected behavior
Redwood leaves should use color providers to increase compatibility with minimap mods and other mods relying on the presence of color providers for leaves.

Additional context
This is mostly a compatibility issue, minimap mods will often use the MapColor or a BlockColorProvider if present. If no BlockColorProvider is present it might appear gray instead.

@LambdAurora LambdAurora added the bug Something isn't working label Jun 9, 2021
@CamoMano CamoMano added the question Further information is requested label Jun 9, 2021
@CamoMano
Copy link
Owner

CamoMano commented Jun 9, 2021

I'll look into this. Could you provide the version of the VanillaEnhanced you are using as well as the name of the minimap mod?

@LambdAurora
Copy link
Author

LambdAurora commented Jun 9, 2021

The version of VanillaEnhanced used is 1.6.1, the minimap mod concerned is LambdaMap. It also affects the content mod Aurora's Decorations as it can't deduce the coloring of the leaf part of the stump block.

Here's a picture of the stump block for example:
image

That's the only missing piece for perfect compatibility.

@CamoMano
Copy link
Owner

CamoMano commented Jun 9, 2021

Are you able to provide me with builds of these mods so I can do some testing?

@LambdAurora
Copy link
Author

I won't be able to provide a build of LambdaMap as I haven't updated it yet, but it's similar to Blockus#71.

For Aurora's Decorations the JAR file can be fetched from the GitHub actions: https://github.com/LambdAurora/AurorasDecorations/suites/2952400489/artifacts/66426089

@CamoMano CamoMano added verified and removed question Further information is requested labels Jun 9, 2021
CamoMano added a commit that referenced this issue Jun 9, 2021
- update mappings
- fixes for issue #28
@CamoMano
Copy link
Owner

CamoMano commented Jun 9, 2021

Thank you. I'll likely release a patch for this later.

@CamoMano CamoMano mentioned this issue Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants