Identity rm

[iurisilvio]

For now, I'm removing all names from cache. I'll change it.

[MaddieM4]

Sounds good. Let me know when it's ready for review!

On Mon, Apr 8, 2013 at 4:53 PM, Iuri de Silvio notifications@github.comwrote:

For now, I'm removing all names from cache. I'll change it.

You can merge this Pull Request by running

git pull https://github.com/iurisilvio/EJTP-lib-python identity-rm

Or view, comment on, or merge it at:

#127
Commit Summary

• ejtp-identity rm working with one valid name
• Add test to ejtp-identity rm with two names
• Test do ejtp-identity rm with an invalid name

File Changes

• M ejtp/tests/test_scripts.pyhttps://github.com/Identity rm #127/files#diff-0(48)
• M scripts/ejtp-identityhttps://github.com/Identity rm #127/files#diff-1(19)

Patch Links:

• https://github.com/campadrenalin/EJTP-lib-python/pull/127.patch
• https://github.com/campadrenalin/EJTP-lib-python/pull/127.diff

[iurisilvio]

It is done, including the rm -A and the error when more than one identity was found.

[MaddieM4]

The output when deleting an identity from multiple caches is a bit messed up. There's no space between "delete" and "from":

philip@philip-desktop:~/projects/EJTP-lib-python$ ejtp-identity rm freckle@lackadaisy.com
Multiple freckle@lackadaisy.com identities found.
Use --cache-source to specify which file to deletefrom or use -A to delete from all sources.

And unless it's prohibitively complex, we should print out a list of all files where freckle@lackadaisy is found.

Other than those two things, this looks spot-on to me.

[iurisilvio]

Fixed the `deletefrom´ issue.

I extended the list_identities to filter only one name, so I just call list_identities(cache_source, by_file=True, name='some@lackadaisy.com') before quit(1).

[MaddieM4]

This looks good to me. Although it has inspired my next issue that I want to make :) Merging and paying now.