Skip to content

Commit

Permalink
Improved efficiency and removed unused import
Browse files Browse the repository at this point in the history
  • Loading branch information
zachartmann committed Aug 29, 2019
1 parent f858c9d commit 48b996c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 49 deletions.
3 changes: 1 addition & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,4 @@ cover
htmlcov
.tox
lib/createsend.egg-info
.rake_tasks~
.idea
.rake_tasks~
57 changes: 10 additions & 47 deletions lib/createsend/journey_email.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
from __future__ import absolute_import

import json

from createsend.createsend import CreateSendBase
from createsend.utils import json_to_py

Expand All @@ -15,62 +13,26 @@ def __init__(self, auth=None, journey_email_id=None):

def bounces(self, date=None, page=None, page_size=None, order_direction=None):
"""Retrieves the bounces for this journey email."""
params = {}
if date is not None:
params["date"] = date
if page is not None:
params["page"] = page
if page_size is not None:
params["pagesize"] = page_size
if order_direction is not None:
params["orderdirection"] = order_direction
response = self._get(self.uri_for("bounces"), params=params)
return json_to_py(response)
return self.get_journey_email_response(date, page, page_size, order_direction, "bounces")

def clicks(self, date=None, page=None, page_size=None, order_direction=None):
"""Retrieves the clicks for this journey email."""
params = {}
if date is not None:
params["date"] = date
if page is not None:
params["page"] = page
if page_size is not None:
params["pagesize"] = page_size
if order_direction is not None:
params["orderdirection"] = order_direction
response = self._get(self.uri_for("clicks"), params=params)
return json_to_py(response)
return self.get_journey_email_response(date, page, page_size, order_direction, "clicks")

def opens(self, date=None, page=None, page_size=None, order_direction=None):
"""Retrieves the opens for this journey email."""
params = {}
if date is not None:
params["date"] = date
if page is not None:
params["page"] = page
if page_size is not None:
params["pagesize"] = page_size
if order_direction is not None:
params["orderdirection"] = order_direction
response = self._get(self.uri_for("opens"), params=params)
return json_to_py(response)
return self.get_journey_email_response(date, page, page_size, order_direction, "opens")

def recipients(self, date=None, page=None, page_size=None, order_direction=None):
"""Retrieves the recipients for this journey email."""
params = {}
if date is not None:
params["date"] = date
if page is not None:
params["page"] = page
if page_size is not None:
params["pagesize"] = page_size
if order_direction is not None:
params["orderdirection"] = order_direction
response = self._get(self.uri_for("recipients"), params=params)
return json_to_py(response)
return self.get_journey_email_response(date, page, page_size, order_direction, "recipients")

def unsubscribes(self, date=None, page=None, page_size=None, order_direction=None):
"""Retrieves the unsubscribes for this journey email."""
return self.get_journey_email_response(date, page, page_size, order_direction, "unsubscribes")

def get_journey_email_response(self, date, page, page_size, order_direction, uri):
"""Retrieves information for the journey email - based on theuri"""
params = {}
if date is not None:
params["date"] = date
Expand All @@ -80,8 +42,9 @@ def unsubscribes(self, date=None, page=None, page_size=None, order_direction=Non
params["pagesize"] = page_size
if order_direction is not None:
params["orderdirection"] = order_direction
response = self._get(self.uri_for("unsubscribes"), params=params)
response = self._get(self.uri_for(uri), params=params)
return json_to_py(response)

def uri_for(self, action):
return "/journeys/email/%s/%s.json" % (self.journey_email_id, action)

0 comments on commit 48b996c

Please sign in to comment.