Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/python3 update #43

Merged
merged 9 commits into from
Jul 1, 2017
Merged

Conversation

djstein
Copy link
Contributor

@djstein djstein commented Jun 12, 2017

Huge Update. Getting back to PEP 8 formatting, remove relative imports, support for Python 3. Leaving my name as author on this branch due to possibility it will never get merged and it being used in our production.

@stewartjarod
Copy link

This would be great 👍

@jdennes
Copy link
Contributor

jdennes commented Jul 1, 2017

I don't use this library, and don't really maintain it either. It is supposed to be officially supported by Campaign Monitor.

These changes look good to me though, and I'm happy to merge this since I still can. If you want a faster response to contributions like this in future, I would recommend contacting Campaign Monitor support about the maintenance plan for libraries like this.

@djstein Thanks for making this better, and you can expect a new release shortly.

@jdennes jdennes merged commit 665cc4c into campaignmonitor:master Jul 1, 2017
@jdennes jdennes mentioned this pull request Jul 1, 2017
@jdennes
Copy link
Contributor

jdennes commented Jul 1, 2017

@xfxf
Copy link

xfxf commented Oct 13, 2017

There appears to be a problem with this release. Can't install 4.2.2 on 3.6.2 on OS X, or 3.4.2 on Linux. pypi shows 'Unknown' as latest version - https://pypi.python.org/pypi/createsend/4.2.2

Same issue:

Collecting createsend==4.2.2
  Using cached createsend-4.2.2.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-fx46u_6d/createsend/setup.py", line 3, in <module>
        from createsend.createsend import __version__
      File "/tmp/pip-build-fx46u_6d/createsend/createsend/__init__.py", line 20, in <module>
        from createsend.version import __version__
    ImportError: No module named 'createsend.version'
    
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-fx46u_6d/createsend/

Installing 4.2.1 works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants