Remove test requirements from install_requires #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Stop using requirements.txt (use setup.py instead). * Remove nose dependecy (plain unittest instead). * Remove lib.release import from setup.py (simple setup.py instead). * Have rake install and use tox to test all python versions (except 3.2 due to broken pip). * Build and upload universal wheels alongside source dists. * Add missing patterns from .gitignore file. * Update RELEASE docs.
|
Changes Unknown when pulling adcaeca on tysonclugg:issue/51-test-requirements into ** on campaignmonitor:master**. |
1 similar comment
|
Changes Unknown when pulling adcaeca on tysonclugg:issue/51-test-requirements into ** on campaignmonitor:master**. |
katharosada
reviewed
Nov 1, 2017
tox.ini
Outdated
|
|
||
| [tox] | ||
| # pip is broken on py32 | ||
| envlist = py23, py24, py25, py26, py27, py30, py31, py33, py34, py35, py36, py37 |
There was a problem hiding this comment.
Please remove py23, py24 and py25 as they're not supported and it looks like Tox is not testing them correctly. I would expect them to fail (missing a json module).
|
@katharosada I've removed the old Python versions as requested. 🙂 |
|
Changes Unknown when pulling ee64741 on tysonclugg:issue/51-test-requirements into ** on campaignmonitor:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #51: