Minor changes to consent_to_track & README.md #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ``consent_to_track`` parameter also accepts a nullable boolean * Added info to README.md about breaking API change
|
@katharosada I'm going to close this; with reflection this API change is confusing (it can now take 6 values, 3 of which are the same) and given this is a breaking change across all libraries, it's not a problem that is particularly unique to this implementation nor deserves to be at the top of the README.md. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consent_to_trackparameter also accepts a nullable booleanAs per issue #62 - allowed consent_to_track parameter to be a boolean, and added info near the top of the README.md which should hopefully help people who upgrade their libraries and find that the API has broken.
I went to add tests, but notice the existing tests don't particularly lend theirselves to testing this (and there aren't any for consent_to_track functionality at the moment). I can add them if needed, but I manually tested this in Python 2.7, Python 3.4 & Python 3.6 and all works as expected.