Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added binary fill to surface labelled droplet reconstruction #371

Conversation

jo-mueller
Copy link
Member

Description

This makes the reconstruction workflow robust for surface-labelled droplets. A remaining concern is what happens to partially labelled droplet or a droplet that has a hole in the labelled area. But maybe that's for a future PR to look at.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

How Has This Been Tested?

  • Workflow tested interactively
  • Workflow tested from notebook

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

jo-mueller and others added 2 commits June 5, 2024 15:17
Co-Authored-By: Carlos Gomez <102696383+carlos-gomez00@users.noreply.github.com>
Co-Authored-By: Schroetinger <11657925+schroetinger@users.noreply.github.com>
@jo-mueller jo-mueller added bug Something isn't working documentation Improvements or additions to documentation labels Jun 6, 2024
@jo-mueller
Copy link
Member Author

@carlos-gomez00 @Schroetinger I did a comparison of the differences in the stresses for the double-labelled droplet. You find all the results in this notebook.

Any comments on something that's missing from the analysis?

@jo-mueller jo-mueller merged commit f5a6104 into campaslab:main Jun 12, 2024
5 of 6 checks passed
@jo-mueller jo-mueller deleted the added-binary-fill-to-surface-labelled-droplet-reconstruction branch June 12, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant