Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid collection-status trunc bug #121

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Conversation

cryptobioz
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 17.604% when pulling b118638 on cryptobioz:master into cafca9b on camptocamp:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 17.604% when pulling 6198194 on cryptobioz:master into cafca9b on camptocamp:master.

break
} else {
log.Debug("No end string found, the collection-status output may be wrong, retrying ...")
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if we reach this and it's still not fine?

if err != nil {
err = fmt.Errorf("failed to launch duplicity: %v", err)
return
for i := 0; i < 2; i++ {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a (static) variable for the number of attempts?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 17.604% when pulling 37d7e08 on cryptobioz:master into cafca9b on camptocamp:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 17.523% when pulling e6e8f48 on cryptobioz:master into cafca9b on camptocamp:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 17.523% when pulling 5adbcd5 on cryptobioz:master into cafca9b on camptocamp:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 17.523% when pulling 5adbcd5 on cryptobioz:master into cafca9b on camptocamp:master.

@raphink
Copy link
Contributor

raphink commented Jun 26, 2017

LGTM.

@raphink raphink merged commit a5b7e2c into camptocamp:master Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants