Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Rancher client timeout #227

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Increase Rancher client timeout #227

merged 1 commit into from
Sep 28, 2018

Conversation

cryptobioz
Copy link
Member

No description provided.

@cryptobioz cryptobioz added this to the 1.0.0-alpha5 milestone Sep 27, 2018
mcanevet
mcanevet reviewed Sep 27, 2018
View reviewed changes
Gopkg.lock Outdated
@@ -104,6 +104,12 @@
packages = ["."]
revision = "23def4e6c14b4da8ac2ed8007337bc5eb5007998"

[[projects]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't have been commited

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder that we should add tests ;-)

@coveralls
Copy link

coveralls commented Sep 27, 2018 •
edited

Pull Request Test Coverage Report for Build 851

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 7.0%
Changes Missing Coverage Covered Lines Changed/Added Lines %
orchestrators/cattle.go 0 1 0.0%
Totals Coverage Status
Change from base Build 849: -0.004%
Covered Lines: 140
Relevant Lines: 2000
💛 - Coveralls

@cryptobioz
Copy link
Member Author

Do not merge until having results from real-world testing.

@cryptobioz
Copy link
Member Author

Seems to fix the problem.

@cryptobioz cryptobioz changed the title [WIP] Increase Rancher client timeout Increase Rancher client timeout Sep 28, 2018
@cryptobioz cryptobioz merged commit 89833e4 into camptocamp:master Sep 28, 2018
@cryptobioz cryptobioz deleted the fix/issue-218 branch September 28, 2018 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcanevet mcanevet mcanevet left review comments

Assignees
No one assigned
Labels
bug orchestrator/cattle
Projects
None yet
Milestone
1.0.0-alpha5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cryptobioz @coveralls @mcanevet