Update NPM Openlayers and closure packages #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "typeahead.js": "=0.10.5" | ||
| "openlayers": "4.5.0", | ||
| "typeahead.js": "=0.10.5", | ||
| "@camptocamp/closure-util": "1.23.0" |
There was a problem hiding this comment.
Is there a reason to not use the closure-util version pointed in openlayers dependencies ?
On my system, everythings seems to work perfectly without pinning closure-util version here.
There was a problem hiding this comment.
Hmmm... I (on Windows) always had some problems with this version, but it does not really matter anymore with the newer ones. So in my opinion, we should not waste too much time on this and close this PR.
OK for you, @arnaud-morvan ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, it does not build using nodejs on Windows. There was something wrong about OL < 4 and Windows, but I cannot remember what.
Maybe this PR is not worthwhile merging with OL 5 soon being released...