feat: add variable for additional alerts labels #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a question: why do this specifically on this module and not generically on the kube-prometheus-stack module? |
|
Because we would like to be able to set additional labels only on certains alerts cause we use them for alerts routing to our Slack and we don't want other ones to be triggered there. |
lentidas
previously approved these changes
Jan 25, 2024
hbollon
force-pushed
the
feat/alert-additional-labels
branch
from
a375af8
to
98daa15
Compare
lentidas
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Add the possibility to add custom alert labels using Terraform variable.
We need it to be able to correctly route alerts to our slack.
Breaking change
Tests executed on which distribution(s)