Allow to pass ArgoCD's Server SecretKey #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what this is trying to solve @mcanevet . What is a use case for this? |
|
@raphink ArgoCD token are signed with the ArgoCD server's sercretkey. If we want to have tokens that are still valid when switching from blue to green, then we have to generate it and pass it as parameter. |
raphink
previously approved these changes
Mar 5, 2021
mcanevet
force-pushed
the
argocd-server-serverkey
branch
from
988607e
to
b973e43
Compare
|
@raphink I rebased. Could you please approve again? |
This is useful when you want your ArgoCD token to still be valid on redeploy.
mcanevet
force-pushed
the
argocd-server-serverkey
branch
from
b973e43
to
e704d00
Compare
raphink
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when you want your ArgoCD token to still be valid on
redeploy.