Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying WMS version #28

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Allow specifying WMS version #28

merged 1 commit into from
Feb 19, 2021

Conversation

jahow
Copy link
Member

@jahow jahow commented Feb 19, 2021

This allows targetting WMS services that do not support version 1.3.0, and as such expect a SRS parameter in the GetMap requests instead of CRS.

tkohr
tkohr approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and requests are sent by ol as expected for the two versions. It might be useful to add the param in the demo specs.

@jahow
Copy link
Member Author

jahow commented Feb 19, 2021

It might be useful to add the param in the demo specs.

Good point. I think the examples need a bit of reworking anyway, I'll look into it. Thanks!

@jahow jahow merged commit d1d5cf9 into master Feb 19, 2021
@jahow jahow deleted the wms-version branch February 19, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkohr tkohr tkohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jahow @tkohr