Expand examples in demo app, add progress bar example #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahow
force-pushed
the
expand-examples
branch
from
ade8cea
to
fd56341
Compare
|
This was rebased, I'm going to merge and continue working on the examples if it's fine for everyone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on making the examples code simpler, in order to be able to "show it" in the demo page eventually.
To do that two custom elements were added:
<custom-button>which makes showing a spinner and a progress bar easier, and<print-spec>which shows the spec editor as well as a dropdown for predefined specs.A new example was added to show how to monitor a job progress with the
getJobStatusapi method.Result:
I split the examples into separate modules so that eventually we can copy the content of these files into the examples page.